Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

[Fix] Generate site map #915

Merged

Conversation

rboixaderg
Copy link
Contributor

@rboixaderg rboixaderg commented Oct 2, 2020

I want to merge this change because...

It fixes the issue #889

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@orzechdev
Copy link
Contributor

Please also add this PR to CHANGELOG.md

@orzechdev orzechdev changed the base branch from master to qa/fix-sitemap-generator October 7, 2020 12:09
@orzechdev
Copy link
Contributor

I have changed base branch to feature branch for QA session

@Sarowar-neo
Copy link

Saleor 2.11.0-rc.1

How can i solve this issue ?

(node:9988) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:9988) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Screenshot from 2020-10-07 18-43-06

@orzechdev orzechdev merged commit a7bf5c5 into saleor:qa/fix-sitemap-generator Oct 23, 2020
maarcingebala added a commit that referenced this pull request Oct 29, 2020
* [Fix] Generate site map

* [Chore] Add PR in changelog

Co-authored-by: Roger Boixader <[email protected]>
Co-authored-by: Marcin Gębala <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants